releasing memory in apply diff #4193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Member
|
Hey @xyOz-dev , thank you. I think this is done by the GC automatically however I don't think it hurts to have this either. Have you seen any other instances of this on other tools? |
Contributor
Author
This simply speeds it up, when we use multiple instances of roo frequently firing this tool it quickly becomes a large issue. so instead of waiting 600-800ms between gc runs, we clear the memory in 50ms or less i havent gotten through all the tools yet as im busy with family, will look more during the week |
mrubens
approved these changes
Jun 2, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: nothing, simply a memory optimization to avoid greyscreens.
Description
This PR addresses a potential memory leak in the applyDiffTool by explicitly releasing the
originalContentbuffer after it's used for diff application.Type of Change
Important
Optimize memory usage in
applyDiffToolby releasingoriginalContentafter use.applyDiffToolfunction inapplyDiffTool.ts, releaseoriginalContentvariable by setting it tonullafter diff application to prevent memory leaks.This description was created by
for 95c005b. You can customize this summary. It will automatically update as commits are pushed.